-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove devcontainer mounts to address error 16 with molecule #3541
Fix: Remove devcontainer mounts to address error 16 with molecule #3541
Conversation
This reverts commit 85c62e2. Keep old version of entry point for the following reasons: 1) to avoid additional testing 2) installing collections from the mount can be useful for future custom cases This can be always reviewed and changed in future.
Switched from |
I'm keeping the logic required to install collections from a bind mount part of the script to cover some special cases that may come in the future and to avoid re-testing the logic. But open for suggestions and alternative opinions. |
fix comment Co-authored-by: Guillaume Mulocher <[email protected]>
Change Summary
This PR addresses a bug with molecule tests failing in AVD dev container due to
error 16: device or resource busy
when bind mount from workspace subdirectory to Ansible collection path is present.As this bind mount is causing significant confusion and increases dev container complexity - it's feasible to remove this option until we have a real use case.
Container can be always rebuild after the change if required to reinstall the collection.
Component(s) name
AVD dev container
Proposed changes
mounts
fromdevcontainer.json
devcontainer.json
onCreateCommand
withpostCreateCommand
(additional testing required before moving this PR out of draft stage)How to test
Start dev container from this branch and test if molecule tests are successful.