Feat(eos_cli_config_gen): Extend router_isis data-model #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
Shivani-gslab
force-pushed
the
#issues3390
branch
from
3630d55 to
49f8b22
Compare
ClausHolbechArista
requested changes
Jan 24, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-isis.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-isis.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-isis.j2
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
#issues3390
branch
2 times, most recently
from
65ad0dc to
f4af9ab
Compare
ClausHolbechArista
approved these changes
Jan 24, 2024
ClausHolbechArista
added
the
one approval
gmuloc
requested changes
Jan 24, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis-new.cfg
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
| - str | ||
| min: 5 | ||
| max: 300 | ||
| description: Number of seconds |
There was a problem hiding this comment.
Suggested change
| description: Number of seconds | |
| description: Number of seconds. |
There was a problem hiding this comment.
Please add dots to every description you are adding in this file
Co-authored-by: Claus Holbech <[email protected]>
Shivani-gslab
force-pushed
the
#issues3390
branch
from
75808df to
c31ee11
Compare
gmuloc
approved these changes
Jan 25, 2024
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Jan 25, 2024
…ks#3539) Co-authored-by: Claus Holbech <[email protected]>
carlbuchmann
removed
the
one approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support in the router_isis data model for:
spf-interval
graceful-restart
bfd all-interfaces under address-family
Related Issue(s)
Fixes #3390
Component(s) name
arista.avd.eos_cli_config_genChecklist
User Checklist
Repository Checklist