Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for virtual topologies constraints #3535

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 23, 2024

Component(s) name

arista.avd.eos_designs

Proposed changes

Add

      wan_virtual_topologies:
        control_plane_virtual_topology:
          constraints:
            # Jitter requirement for this load balance policy in milliseconds.
            jitter: <int; 0-10000>
            # One way delay requirement for this load balance policy in milliseconds.
            latency: <int; 0-10000>
            # Loss Rate requirement in percentage for this load balance policy.
            # Value between 0.00 and 100.00 %
            loss_rate: <str>
        policies:
          application_virtual_topologies:
                constraints:
                  # Jitter requirement for this load balance policy in milliseconds.
                  jitter: <int; 0-10000>
                  # One way delay requirement for this load balance policy in milliseconds.
                  latency: <int; 0-10000>
                  # Loss Rate requirement in percentage for this load balance policy.
                  # Value between 0.00 and 100.00 %
                  loss_rate: <str>
           default_virtual_topology:
                constraints:
                  # Jitter requirement for this load balance policy in milliseconds.
                  jitter: <int; 0-10000>
                  # One way delay requirement for this load balance policy in milliseconds.
                  latency: <int; 0-10000>
                  # Loss Rate requirement in percentage for this load balance policy.
                  # Value between 0.00 and 100.00 %
                  loss_rate: <str>

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc self-assigned this Jan 23, 2024
@gmuloc gmuloc requested review from a team as code owners January 23, 2024 16:24
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 23, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion on refactoring, I'm also ok as is!
Tested with lab.

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Jan 24, 2024
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Jan 24, 2024
@ClausHolbechArista ClausHolbechArista merged commit f0c3986 into aristanetworks:devel Jan 24, 2024
41 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Feb 1, 2024
@gmuloc gmuloc deleted the add-constraint-to-avts branch January 17, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants