Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Support routing protocol option on l3_edge p2p_links #3516

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Feat(eos_designs): Support routing protocol option on l3_edge p2p_links #3516

merged 3 commits into from
Feb 6, 2024

Conversation

kornoa
Copy link
Contributor

@kornoa kornoa commented Jan 19, 2024

Change Summary

Implement an additional key in

  • l3_edge.p2p_links_profiles[].routing_protocol
  • l3_edge.p2p_links[].routing_protocol
  • core_interfaces.p2p_links_profiles[].routing_protocol and
  • core_interfaces.p2p_links[].routing_protocol

to overwrite underlay routing protocol used on the link. Currently only ebgp is implemented which enforces classic IPv4 BGP Peering in a RFC5549 enabled fabric.

Related Issue(s)

Fixes #3493

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Added the new keys to the role schema
  • Changed the structured config generation in corresponding underlay python module

How to test

  • Added a test case to molecule scenario evpn_underlay_rfc5549_overlay_ebgp

Checklist

Repository Checklist

  • [ x] My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@kornoa kornoa requested review from a team as code owners January 19, 2024 11:01
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 19, 2024
ClausHolbechArista
ClausHolbechArista reviewed Jan 20, 2024
View reviewed changes
...sta/avd/molecule/evpn_underlay_rfc5549_overlay_ebgp/intended/structured_configs/DC1-BL1A.yml Outdated
shutdown: false
mtu: 1500
ip_address: 10.23.23.1/30
ipv6_enable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have set ipv6_enable specifically to False. That should not even be necessary. Instead add your extra condition for routing_protocol != "ebgp" to the place where we generate ipv6 based on 5549. (It should still be possible to generate ipv6_enable if specifically set to true)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'm on vacation this week. I'll commit the change to the PR next week.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put this in draft for now. Set as ready once you have updated. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft January 22, 2024 16:44
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@kornoa kornoa marked this pull request as ready for review February 2, 2024 11:32
@kornoa kornoa marked this pull request as draft February 2, 2024 11:34
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kornoa kornoa marked this pull request as ready for review February 2, 2024 11:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 3, 2024
Shivani-gslab
Shivani-gslab approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista
Copy link
Contributor

Approved. I will resolve the conflict once we have merged #3584.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit c80704e into aristanetworks:devel Feb 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@kornoa kornoa

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Support BGP ipv4 unicast peering on l3_edge.p2p_links within a RFC5549 enabled fabric
3 participants
@kornoa @ClausHolbechArista @Shivani-gslab