Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Do not KeyError when no path-group is in common with pathfinder #3512

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix(eos_designs): Do not KeyError when no path-group is in common with pathfinder #3512

merged 1 commit into from
Jan 18, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jan 17, 2024

Change Summary

Fix KeyError found

Related Issue(s)

Fixes #3511

Component(s) name

arista.avd.eos_designs

Proposed changes

  • use get instead of dict key access
  • add molecule test
  • fix doc (not related)
  • fix typo in error message (not related)

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners January 17, 2024 20:44
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 17, 2024
carlbuchmann
carlbuchmann approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in lab topology

@carlbuchmann carlbuchmann requested a review from a team January 18, 2024 02:07
@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Jan 18, 2024
@ClausHolbechArista ClausHolbechArista merged commit 20f7c7e into aristanetworks:devel Jan 18, 2024
37 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Feb 1, 2024
@gmuloc gmuloc deleted the issue/3511 branch January 17, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix(eos_designs): Do not KeyError when no path-group is in common with pathfinder
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista