-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Interface "LACP Fallback Individual" Support #3510
Merged
ClausHolbechArista
merged 21 commits into
aristanetworks:devel
from
bjmeuer:endpoints_lacp_fallback_individual
Jan 24, 2024
Merged
Feat(eos_designs): Interface "LACP Fallback Individual" Support #3510
ClausHolbechArista
merged 21 commits into
aristanetworks:devel
from
bjmeuer:endpoints_lacp_fallback_individual
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cp fallback individual
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Jan 17, 2024
...lections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/connected_endpoints.cfg
Outdated
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/connected_endpoints.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/port-profiles.md
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jan 18, 2024
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
…s/connected_endpoints/ethernet_interfaces.py Co-authored-by: Claus Holbech <[email protected]>
…s/connected_endpoints/ethernet_interfaces.py Co-authored-by: Claus Holbech <[email protected]>
…s/connected_endpoints/ethernet_interfaces.py Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
requested changes
Jan 18, 2024
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
…s/connected_endpoints/ethernet_interfaces.py Co-authored-by: Claus Holbech <[email protected]>
…o influence on the port-channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code optimization. Done by hand so may require linting.
...s/arista/avd/roles/eos_designs/python_modules/connected_endpoints/port_channel_interfaces.py
Outdated
Show resolved
Hide resolved
…s/connected_endpoints/port_channel_interfaces.py Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
approved these changes
Jan 19, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Jan 19, 2024
ankudinov
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested various combinations in Codespace
carlbuchmann
removed
the
one approval
This PR has one approval and is only missing one more.
label
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adding "LACP Fallback Individual" to the eos_designs. This is a common requirement for automated server deployments in order to bootstrap bare-metal servers via a different VLAN or interface type (for example) than is configured against the port-channel interface. Also adding the ability to specify different interface configuration parameters at the member interface level than are specified at the port-channel level by using port_profiles.
Related Issue(s)
Fixes #3367
Component(s) name
arista.avd.eos_designs
Proposed changes
The option "individual" was added to the "mode" key of the lacp_fallback setting. Additionally added the setting "individual" with the key "profile" where you can reference a port_profile from which you want to inherit configuration for the member interfaces. The following config from a port_profile will be inherited: mode, vlans, native_vlan, native_vlan_tag.
How to test
From the molecule tests:
Checklist
User Checklist
Repository Checklist