Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Preview - Generate CV tags #3472

Merged
merged 68 commits into from
Jan 12, 2024
Merged

Feat(eos_designs): Preview - Generate CV tags #3472

merged 68 commits into from
Jan 12, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jan 5, 2024 •
edited
Loading

Change Summary

Preview - Generate CV tags

Component(s) name

arista.avd.eos_designs

Proposed changes

Produce metadata.cv_tags in the structured configs with topology hints and/or generated custom tags.

How to test

TODO: All test for a full fabric including some custom tags.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role and removed type: documentation Improvements or additions to documentation type: code quality CI and development toolset labels Jan 5, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat/eos designs/generate cv tags Feat(eos designs): Generate CV tags Jan 5, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos designs): Generate CV tags Feat(eos_designs): Generate CV tags Jan 5, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review January 8, 2024 18:16
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners January 8, 2024 18:16
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Generate CV tags Preview(eos_designs): Generate CV tags Jan 8, 2024
@ClausHolbechArista ClausHolbechArista changed the title Preview(eos_designs): Generate CV tags Feat(eos_designs): PREVIEW - Generate CV tags Jan 8, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): PREVIEW - Generate CV tags Feat(eos_designs): Preview - Generate CV tags Jan 8, 2024
noredistribution
noredistribution reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like in mkdocs.yml under eos_designs in the How-To Guides we are missing - CloudVIsion Tags: roles/eos_designs/docs/how-to/cloudvision-tags.md

          - How-To Guides:
              - Configuring PTP: roles/eos_designs/docs/how-to/ptp.md
              - Custom Structured Configuration: roles/eos_designs/docs/how-to/custom-structured-configuration.md
              - Custom Templates: roles/eos_designs/docs/how-to/custom-templates.md

chetryan and others added 20 commits January 11, 2024 08:30
@chetryan @ClausHolbechArista
Fix: Remove faulty delegation test
8bc22b5 
Could not find a test to ensure the role had been delegated
that works 100% of the time, so it's better to remove it than
give false sense of security to user.
@chetryan @ClausHolbechArista
FIX: make device_tags or interfac_tags optional
1baf8db
@chetryan @ClausHolbechArista
Fix: Update molecule test to cover more scenarios
8ea5049
@chetryan @ClausHolbechArista
FIX: Update the molecule
1bfd987
@chetryan @ClausHolbechArista
FIX(eos_designs): Rename field to data_path
b039f61
@chetryan @ClausHolbechArista
FIX(eos_designs): Use the shared_utils.rack information
da98d61
@chetryan @ClausHolbechArista
FIX(eos_designs) Simplify molecule test topology
06bf45c
@chetryan @ClausHolbechArista
Fix(eos_designs): fix molecule test
4ec805b
@ClausHolbechArista
Remove cloudvision role
28f0a18
@ClausHolbechArista
Revert more things
308a76d
@ClausHolbechArista
Revert more things
0eccd8a
@ClausHolbechArista
Move cv_tags to metadata
244e825
@ClausHolbechArista
rerun molecule
aa9c06a
@ClausHolbechArista
Minor updates
013050d
@ClausHolbechArista
precommit fixes
15bce40
@ClausHolbechArista
Update data model
37d7356
@ClausHolbechArista
fix bad link
57dae58
@ClausHolbechArista
Update doc
ffba57c
@ClausHolbechArista
Add preview to docs and schemas
f8e517c
@ClausHolbechArista
Add molecule tests
ebdd550
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/generate_cv_tags branch from 176ee73 to ebdd550 Compare January 11, 2024 07:46
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 11, 2024
Merged
4 tasks
noredistribution
noredistribution approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm+1

@gmuloc gmuloc merged commit cb0c58d into aristanetworks:devel Jan 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noredistribution noredistribution noredistribution approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ClausHolbechArista @gmuloc @noredistribution @chetryan