Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): IPv6 inband management settings #3382

Merged
merged 31 commits into from
Feb 29, 2024
Merged

Feat(eos_designs): IPv6 inband management settings #3382

merged 31 commits into from
Feb 29, 2024
+3,449 −92

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Nov 27, 2023 •
edited
Loading

Change Summary

Adds IPv6 settings for inband management to eos_designs.

Related Issue(s)

Fixes #3325
Depends on #3564

Component(s) name

arista.avd.eos_designs

Proposed changes

node_type_keys.key:
  ...
  nodes:
    - name: v6-inband
      inband_mgmt_ipv6_address: < v6 stuff >
      inband_mgmt_ipv6_gateway: < v6 stuff >
      inband_mgmt_ipv6_subnet: < v6 stuff >

How to test

Tested using molecule.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Nov 27, 2023
@emilarista emilarista marked this pull request as ready for review December 14, 2023 15:14
@emilarista emilarista requested review from a team as code owners December 14, 2023 15:14
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 19, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@emilarista emilarista marked this pull request as draft January 18, 2024 11:12
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 8, 2024
ClausHolbechArista
ClausHolbechArista approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista requested a review from a team February 14, 2024 08:51
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 14, 2024
@emilarista
Copy link
Contributor Author

Just for information: The customer who requested this feature has tested the PR and signed off on the generated config.

gmuloc
gmuloc reviewed Feb 26, 2024
View reviewed changes
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Outdated Show resolved Hide resolved
onurgashi
onurgashi approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@onurgashi onurgashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the output shows that this generates the expected config. Thanks a lot!

gmuloc
gmuloc reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more refactoring to your function :)

...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_designs/python_modules/inband_management/avdstructuredconfig.py Outdated Show resolved Hide resolved
@gmuloc gmuloc merged commit e306b48 into aristanetworks:devel Feb 29, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 2, 2024
@emilarista @ClausHolbechArista
@gmuloc @pre-commit-ci-lite @sugetha24
Feat(eos_designs): IPv6 inband management settings (aristanetworks#3382)
5f5d315 
Co-authored-by: Claus Holbech <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@emilarista emilarista deleted the inband_ipv6 branch December 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurgashi onurgashi onurgashi approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

@alexeygorbunov alexeygorbunov Awaiting requested review from alexeygorbunov

Assignees

@onurgashi onurgashi

@emilarista emilarista

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IPv6 addresses for inband management of sub-leafs (l2leafs)
4 participants
@emilarista @gmuloc @ClausHolbechArista @onurgashi