Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Minor grammar edits. #3362

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

blitzeditor
Copy link
Collaborator

@blitzeditor blitzeditor commented Nov 20, 2023

Change Summary

Corrected minor grammar errors.

Component(s) name

Documentation

How to test

Please see the generated site on CI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@blitzeditor blitzeditor requested review from a team as code owners November 20, 2023 18:07
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Nov 20, 2023
@blitzeditor blitzeditor changed the title Minor grammar edits. Doc: Minor grammar edits. Nov 20, 2023
@blitzeditor blitzeditor marked this pull request as draft November 20, 2023 22:41
@blitzeditor
Copy link
Collaborator Author

blitzeditor commented Nov 27, 2023 via email

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 16, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 22, 2024
@JulioPDX JulioPDX marked this pull request as ready for review April 22, 2024 17:57
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and suggested one correction on a typo.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label May 27, 2024
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
D Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 19, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc requested a review from carlbuchmann June 19, 2024 08:10
@gmuloc gmuloc added this to the v4.9.0 milestone Jun 19, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 19, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit c2fa30f into aristanetworks:devel Jun 19, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Doc type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants