Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Extend sbfd for initiator measurement round-trip #3347

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Feat(eos_cli_config_gen): Extend sbfd for initiator measurement round-trip #3347

merged 2 commits into from
Nov 16, 2023
+26 −4

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented Nov 15, 2023 •
edited
Loading

Change Summary

Add support for defining the initiator measurement delay round-trip through eos_cli_config_gen data model rather than raw commands using the eos_cli field.

Related Issue(s)

Fixes #3343

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Update the schema to support turning on initiator measurement delay round-trip
  • Update the platform eos & documentation templates to generate the line initiator measurement delay round-trip as part of the sbfd config
  • Update the molecule test eos_cli_config_gen

How to test

  • use molecule test -s eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 15, 2023
@chetryan chetryan marked this pull request as ready for review November 15, 2023 17:05
@chetryan chetryan requested review from a team as code owners November 15, 2023 17:05
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 16, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team November 16, 2023 13:38
@gmuloc gmuloc merged commit 05e3914 into aristanetworks:devel Nov 16, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@chetryan chetryan

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
US-PROJECT-02
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(eos_cli_config_gen) Extend sbfd functionality
3 participants
@chetryan @gmuloc @ClausHolbechArista