-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Adding options for path-selection lb policies #3334
Feat(eos_cli_config_gen): Adding options for path-selection lb policies #3334
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
32b23e4
to
7113420
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking data model change is OK since we have not released the old data model. LGTM (a few comments)
...ollections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-path-selection.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-path-selection.md
Outdated
Show resolved
Hide resolved
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_path_selection.schema.yml
Outdated
Show resolved
Hide resolved
633ee68
to
4ce6c34
Compare
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_path_selection.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-path-selection.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-path-selection.j2
Outdated
Show resolved
Hide resolved
...ections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-path-selection.yml
Outdated
Show resolved
Hide resolved
...ollections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-path-selection.cfg
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-path-selection.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-path-selection.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-path-selection.md
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.jsonschema.json
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.yml
Outdated
Show resolved
Hide resolved
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_path_selection.schema.yml
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.jsonschema.json
Outdated
Show resolved
Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-path-selection.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes!
…tes/documentation/router-path-selection.j2 Co-authored-by: Carl Buchmann <[email protected]>
fc74a76
to
6f24438
Compare
Change Summary
Adding new options to
router_path_selection.load_balancing_policies
NOTE - updating the schema for
path_groups
but it is ok as we have not released it yet (except in a dev release)Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
cf schema update.
NOTE: The sorting of path-groups is done per priority and then per alphabetical order. When no priority is given by the user in the schema, the priority is
1
and when priority is set to 1 in CLI it is not rendered (Cf below)For now because of Ansible version 2.13 and its overwriting of Jinja2 groupby filter that does not support default, a cumbersome injection of priority
1
is made when it is not set to allow for a proper sorting.How to test
molecule
Checklist
Repository Checklist