Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Adding options for path-selection lb policies #3334

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 10, 2023

Change Summary

Adding new options to router_path_selection.load_balancing_policies

NOTE - updating the schema for path_groups but it is ok as we have not released it yet (except in a dev release)

       load_balance_policies:
         - name: <str>
+          hop_count_lower: <bool>
+          jitter: <int>
           latency: <int>
+          loss_rate: <str>
           path_groups:
-            - <str>
+            - name: <str>
+              priority: <int>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

cf schema update.

NOTE: The sorting of path-groups is done per priority and then per alphabetical order. When no priority is given by the user in the schema, the priority is 1 and when priority is set to 1 in CLI it is not rendered (Cf below)

For now because of Ansible version 2.13 and its overwriting of Jinja2 groupby filter that does not support default, a cumbersome injection of priority 1 is made when it is not set to allow for a proper sorting.

router path-selection
   load-balance policy DEMO
      no latency
      no jitter
      loss-rate 42.42
      path-group BLAH priority 42
host1(config-load-balance-policy-DEMO)#path-group BLEH priority 12
host1(config-load-balance-policy-DEMO)#show active
router path-selection
   load-balance policy DEMO
      loss-rate 42.42
      path-group BLEH priority 12
      path-group BLAH priority 42
host1(config-load-balance-policy-DEMO)#path-group BLUH pr 1
host1(config-load-balance-policy-DEMO)#show active
router path-selection
   load-balance policy DEMO
      loss-rate 42.42
      path-group BLIH
      path-group BLUH
      path-group BLEH priority 12
      path-group BLAH priority 42

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 10, 2023
@gmuloc gmuloc changed the title Feat(eos_cli_config_gen): Adding latency for path-selection lb policies Feat(eos_cli_config_gen): Adding options for path-selection lb policies Nov 10, 2023
@gmuloc gmuloc marked this pull request as ready for review November 10, 2023 11:04
@gmuloc gmuloc requested review from a team as code owners November 10, 2023 11:04
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc force-pushed the update-router-path-selection branch from 32b23e4 to 7113420 Compare November 13, 2023 09:22
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 13, 2023
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking data model change is OK since we have not released the old data model. LGTM (a few comments)

@ClausHolbechArista ClausHolbechArista requested a review from a team November 13, 2023 11:56
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 13, 2023
@gmuloc gmuloc force-pushed the update-router-path-selection branch from 633ee68 to 4ce6c34 Compare November 13, 2023 17:47
@gmuloc gmuloc requested review from a team November 14, 2023 14:04
@gmuloc gmuloc requested a review from carlbuchmann November 15, 2023 10:54
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes!

@gmuloc gmuloc force-pushed the update-router-path-selection branch from fc74a76 to 6f24438 Compare November 15, 2023 12:54
@ClausHolbechArista ClausHolbechArista merged commit 3557bbe into aristanetworks:devel Nov 16, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants