-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add default_mgmt_method
to be used later in new management settings.
#3328
Merged
carlbuchmann
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:feat/eos_designs/default-mgmt-method
Nov 9, 2023
Merged
Feat(eos_designs): Add default_mgmt_method
to be used later in new management settings.
#3328
carlbuchmann
merged 7 commits into
aristanetworks:devel
from
ClausHolbechArista:feat/eos_designs/default-mgmt-method
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…management settings.
carlbuchmann
reviewed
Nov 8, 2023
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.jsonschema.json
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/default_mgmt_method.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
ansible_collections/arista/avd/roles/eos_designs/docs/tables/management-interface-settings.md
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/default_mgmt_method.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/default_mgmt_method.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
reviewed
Nov 8, 2023
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Nov 9, 2023
gmuloc
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once docstring is updated
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/mgmt.py
Show resolved
Hide resolved
jonxstill
pushed a commit
to jonxstill/ansible-avd
that referenced
this pull request
Nov 14, 2023
…management settings. (aristanetworks#3328) Co-authored-by: Carl Buchmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add
default_mgmt_method
to be used later in new management settings.Component(s) name
arista.avd.eos_designs
Proposed changes
This is a no-op currently.
How to test
This has no functionality right now. Tests will be added as part of the associated management protocol PRs
Checklist
User Checklist
Repository Checklist