Feat(eos_cli_config_gen): Extend CLI model for ip_security #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
I haven't figured out how to show the added CLI options on the documentation table. I was hoping that the table would automatically include them when I ran the pre-commit to build the AVD schemas, but it doesn't seem to be the case |
|
Remember to stage your files when running pre-commit. Or run with |
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
Pls ignore this, I need to remember to stage the docs J2 template :) |
gmuloc
reviewed
Nov 9, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ip-security.j2
Outdated
Show resolved
Hide resolved
gmuloc
requested changes
Nov 9, 2023
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_security.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/ip-security.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Mulocher <[email protected]>
sugetha24
force-pushed
the
issue3310-ip-security
branch
from
c552e70 to
b089573
Compare
ClausHolbechArista
approved these changes
Nov 10, 2023
jonxstill
pushed a commit
to jonxstill/ansible-avd
that referenced
this pull request
Nov 14, 2023
…works#3312) Co-authored-by: Claus Holbech <[email protected]> Co-authored-by: Guillaume Mulocher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds CLI support for the following:
See related issue
Related Issue(s)
Fixes #3310
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Extend Jinja2 template for
ip_securityto support extra CLI options for IKE profilesHow to test
See molecule tests
Checklist
User Checklist
Repository Checklist