Feat(eos_cli_config_gen): Support for setting default QSFP transceiver mode #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
Comment on lines
12
to
15
| description: | | ||
| The `transceiver_qsfp_default_channelized` knob allows to comply with the change of default QSFP mode for Tomahawk and Trident based devices (40G instead of 4x10G). | ||
| This change has been introduced starting from EOS version 4.26.0F. | ||
| The user should not configure the knob to `false` for other type of platforms or for a lower EOS version. |
There was a problem hiding this comment.
So I think there is more to this than this reason, since newer EOS versions have removed the command from defaults on other platforms. I think we need to document this with broader terms.
Let's discuss internally.
There was a problem hiding this comment.
The description has been updated inspired from the EOS guide: https://www.arista.com/en/um-eos/eos-ethernet-ports
| # Use Ctrl + Space to get suggestions for every field. Autocomplete will pop up after typing 2 letters. | ||
| type: dict | ||
| keys: | ||
| transceiver_qsfp_default_channelized: |
There was a problem hiding this comment.
Suggested change
| transceiver_qsfp_default_channelized: | |
| transceiver_qsfp_default_mode_channelized: |
There was a problem hiding this comment.
updated to transceiver_qsfp_default_mode_4x10: to align closer to the EOS CLI
...llections/arista/avd/roles/eos_cli_config_gen/templates/eos/transceiver-qsfp-default-mode.j2
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/eos/transceiver-qsfp-default-mode.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
changed the title
|
Moving to draft until we have sorted out the description and key name. |
mmaaloul
force-pushed
the
fix_issue_3261
branch
from
c200f02 to
e5dd733
Compare
...cli_config_gen/schemas/schema_fragments/transceiver_qsfp_default_mode_channelized.schema.yml
Show resolved
Hide resolved
...cli_config_gen/schemas/schema_fragments/transceiver_qsfp_default_mode_channelized.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
force-pushed
the
fix_issue_3261
branch
from
e2b2061 to
a07e4e4
Compare
...tions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/generate-default-config.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jan 16, 2024
...olecule/eos_cli_config_gen/documentation/devices/transceiver_qsfp_default_mode_4x10_false.md
Outdated
Show resolved
Hide resolved
…umentation/devices/transceiver_qsfp_default_mode_4x10_false.md
...olecule/eos_cli_config_gen/documentation/devices/transceiver_qsfp_default_mode_4x10_false.md
Outdated
Show resolved
Hide resolved
…umentation/devices/transceiver_qsfp_default_mode_4x10_false.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
To be compliant with the new default QSFP mode for various platforms in EOS 4.26.0+ (40G instead of 4x10G), we are allowing the user to dismiss the
transceiver qsfp default-mode 4x10Gconfig.In AVD 5.0.0 the default will be flipped to not generate this command unless this key is set to true.
Related Issue(s)
Fixes #3261
Component(s) name
arista.avd.eos_cli_config_genProposed changes
1/ Introduced a new var
transceiver_qsfp_default_channelizedof type boolean:transceiver qsfp default-mode 4x10Gis includedfalse, configtransceiver qsfp default-mode 4x10Gis not included2/ var
generate_default_configno longer control the default qsfp mode configurationHow to test
Changed host
generate-default-config: vargenerate-default-configchanged totruewhile vargenerate_default_configis set tofalse. Confirmed that configtransceiver qsfp default-mode 4x10Gdoes not show up in the intended configChecklist
User Checklist
Repository Checklist