Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Wrong CLI template for some ip_security options #3263

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix(eos_cli_config_gen): Wrong CLI template for some ip_security options #3263

merged 1 commit into from
Oct 19, 2023
+10 −10

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 18, 2023

Change Summary

During implementation of ip-security the template was not correctly implemented for two keys. This PR is fixing this.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • pfs_dh_group 14 -> pfs dh-group 14
  • local_id 192.168.99.1 -> local-id 192.168.99.1

How to test

molecule updated

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 18, 2023 22:24
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Oct 18, 2023
carlbuchmann
carlbuchmann approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, successfully applied config on DUT

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Oct 19, 2023
@carlbuchmann carlbuchmann added this to the v4.5.0-dev1 milestone Oct 19, 2023
@ClausHolbechArista ClausHolbechArista merged commit 232ca91 into aristanetworks:devel Oct 19, 2023
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Wrong CLI template for some options Fix(eos_cli_config_gen): Wrong CLI template for some ip_security options Oct 19, 2023
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
@gmuloc gmuloc deleted the fix-ip-security-template branch January 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.5.0-dev1
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista