-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add knob to define port in GNMI transport grpc #3245
Feat(eos_cli_config_gen): Add knob to define port in GNMI transport grpc #3245
Conversation
...ns/arista/avd/molecule/eos_cli_config_gen/documentation/devices/management-gnmi-new-flags.md
Show resolved
Hide resolved
should we update the documentation? changing the gRPC Port might require update to the control-plane ACL |
I can add a note to the description for sure, give me 1 h
…On Mon, Oct 16, 2023, 12:37 p.m. Tamas Plugor ***@***.***> wrote:
should we update the documentation? changing the gRPC Port might require
update to the control-plane ACL
—
Reply to this email directly, view it on GitHub
<#3245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEBMWKPPQYPRZJWJXFZRATX7VPFLAVCNFSM6AAAAAA6CKA3NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUHA3DIOJXHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works fine for me, I'd just add that note about the CP ACL and then it's good to go
updated schema fragment description with your recommendation. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_api_gnmi.schema.yml
Outdated
Show resolved
Hide resolved
…s/schema_fragments/management_api_gnmi.schema.yml Co-authored-by: Guillaume Mulocher <[email protected]>
trimming white space
Change Summary
Add the capacity to define a custom port in management api gnmi for transport grpc
Related Issue(s)
N/A
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
see molecule tests :
management-gnmi.yml
management-gnmi-new-flags.yml
Checklist
User Checklist
Repository Checklist