Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Implement next-hop resolution disabled for evpn address-family #3218

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 6, 2023

Change Summary

Model can be challenged - only implementing what is needed for WAN config so skipping vxlan and mpls keywords

ceos2(config-router-bgp-af)#show cli commands | grep next-hop
[...]
[no|default] next-hop mpls resolution ribs ( { system-connected | system-unicast-rib | ( tunnel-rib ( system-tunnel-rib | ( colored system-colored-tunnel-rib ) | TUNNEL_RIB ) ) } )
[no|default] next-hop resolution disabled
[no|default] next-hop vxlan resolution ribs ( system-connected | system-unicast-rib )```

## Component(s) name

`arista.avd.eos_cli_config_gen`

## Proposed changes

      next_hop:
        type: dict
        keys:
          resolution_disabled:
            type: bool

## How to test

molecule

## Checklist


### Repository Checklist

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code has been rebased from devel before I start
- [x] I have read the [**CONTRIBUTING**](https://avd.sh/en/latest/docs/contribution/overview.html) document.
- [x] My change requires a change to the documentation and documentation have been updated accordingly.
- [x] I have updated [molecule CI](https://github.com/aristanetworks/ansible-avd/tree/devel/ansible_collections/arista/avd/molecule) testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 6, 2023 09:30
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 6, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 6, 2023 09:38
@ClausHolbechArista ClausHolbechArista merged commit 8207619 into aristanetworks:devel Oct 6, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants