Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add IPv4 and IPv6 SR-TE address families #3217

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 6, 2023

Change Summary

Add SR-TE BGP address families - ipv4 one is required for WAN config and it was cheap to add v6 at the same time.

Component(s) name

arista.avd.eos_cli_config_gem

Proposed changes

      address_family_ipv4_sr_te:
        neighbors:
          - ip_address: <str>
            activate: <bool>
            route_map_in: <str>
            route_map_out: <str>
        peer_groups:
          - name: <str>
            activate: <bool>
            route_map_in: <str>
            route_map_out: <str>
[...]
      address_family_ipv6_sr_te:
        neighbors:
          - ip_address: <str>
            activate: <bool>
            route_map_in: <str>
            route_map_out: <str>
        peer_groups:
          - name: <str>
            activate: <bool>
            route_map_in: <str>
            route_map_out: <str>

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 6, 2023 09:14
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 6, 2023
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only a minor adjustment to the schema.

@ClausHolbechArista ClausHolbechArista requested a review from a team October 6, 2023 10:17
@emilarista emilarista self-requested a review October 10, 2023 10:35
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 0e1875e into aristanetworks:devel Oct 10, 2023
@gmuloc gmuloc deleted the router-bgp-sr-te branch January 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants