Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Correct schema for class-maps vlans and cos options #3215

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Correct schema for class-maps vlans and cos options

Related Issue(s)

Fixes #3214
Fixes #3165

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Change schema type to string for fields supporting ranges.

How to test

Added tests of ranges to molecule scenario.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners October 6, 2023 04:24
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 6, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.4.0 milestone Oct 6, 2023
@gmuloc gmuloc requested a review from a team October 6, 2023 08:28
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 6e1d687 into aristanetworks:devel Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validation error for class-maps - vlan variable (integer instead of string?)
3 participants