-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants #3201
Merged
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
jonxstill:evpn_multicast_rp_acl
Oct 16, 2023
Merged
Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants #3201
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
jonxstill:evpn_multicast_rp_acl
Oct 16, 2023
+271
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Oct 4, 2023
4 tasks
ClausHolbechArista
changed the title
Feat(eos_designs): Support for access_list_name under VRFs and Tenants
Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants
Oct 6, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jonxstill
force-pushed
the
evpn_multicast_rp_acl
branch
from
October 13, 2023 16:09
611e124
to
3b0490d
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Tested this and works as expected. |
...tions/arista/avd/roles/eos_designs/python_modules/network_services/utils_filtered_tenants.py
Outdated
Show resolved
Hide resolved
jonxstill
force-pushed
the
evpn_multicast_rp_acl
branch
from
October 16, 2023 12:50
a3c6b00
to
fc9f137
Compare
ClausHolbechArista
approved these changes
Oct 16, 2023
Merging since @perimore also tested and approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Support use of
access_list_name
under VRFs and Tenants, in a similar way tounderlay_multicast_rps
.Related Issue(s)
Fixes #2881
Component(s) name
arista.avd.eos_designs
Proposed changes
Data Model:
Behaviour is identical to that in #2846:
How to test
Molecule tests modified to cover this case.
If you have an existing RP config on your PEGs you should be able to add the
access_list_name
key to an existing RP entry (value is the name of the ACL) and instead of specifying the groups on therp address
command, the generated config should refer to the ACL, which should contain the same groups that were configured on therp address
command.Checklist
User Checklist
Repository Checklist