Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants #3201

Merged

Conversation

jonxstill
Copy link
Contributor

@jonxstill jonxstill commented Oct 4, 2023

Change Summary

Support use of access_list_name under VRFs and Tenants, in a similar way to underlay_multicast_rps.

Related Issue(s)

Fixes #2881

Component(s) name

arista.avd.eos_designs

Proposed changes

Data Model:

< network_services_keys.key_1 >:
  < tenant_a >:
    pim_rp_addresses:
      - rps:
          - <str>
        groups:
          - <str>
        access_list_name: <str>
    vrfs:
      < tenant_a_vrf_1 >:
        pim_rp_addresses:
          - rps:
              - <str>
            groups:
              - <str>
            access_list_name: <str>

Behaviour is identical to that in #2846:

List of groups to associate with the RP addresses set in 'rps'.
If access_list_name is set, a standard access-list will be configured matching these groups.
Otherwise the groups are configured directly on the RP command.

How to test

Molecule tests modified to cover this case.
If you have an existing RP config on your PEGs you should be able to add the access_list_name key to an existing RP entry (value is the name of the ACL) and instead of specifying the groups on the rp address command, the generated config should refer to the ACL, which should contain the same groups that were configured on the rp address command.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 4, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Support for access_list_name under VRFs and Tenants Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants Oct 6, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 13, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jonxstill jonxstill force-pushed the evpn_multicast_rp_acl branch from 611e124 to 3b0490d Compare October 13, 2023 16:09
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 13, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jonxstill jonxstill marked this pull request as ready for review October 16, 2023 10:32
@jonxstill jonxstill requested review from a team as code owners October 16, 2023 10:32
@perimore
Copy link
Contributor

Tested this and works as expected.

@jonxstill jonxstill force-pushed the evpn_multicast_rp_acl branch from a3c6b00 to fc9f137 Compare October 16, 2023 12:50
@ClausHolbechArista ClausHolbechArista requested a review from a team October 16, 2023 14:02
@ClausHolbechArista ClausHolbechArista merged commit 310beea into aristanetworks:devel Oct 16, 2023
@ClausHolbechArista
Copy link
Contributor

Merging since @perimore also tested and approved.

@jonxstill jonxstill deleted the evpn_multicast_rp_acl branch October 16, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add access_list_name support to pim_rp_addresses under tenants and VRFs
3 participants