Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add Dps1 interface #3198

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 4, 2023

Change Summary

Add first implementation of Dps1 interface with required fields for AutoVPN / WAN config

NOTE: While not needed to merge this PR note that current devel branch DOES NOT support flow tracker hardware type in flow_trackers - #3199

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Schema using eos_cli escape hatch as for now it is unclear how other commands could be needed

    dps_interfaces:
      - name: <str>  # Only Dps1 is a valid value
        description: <str>
        ip_address: <str>
        flow_tracker:
          sampled: <str>
          hardware: <str>
        tcp_mss_ceiling:
          ipv4: <int>
          ipv6: <int>
          direction: <str>
        eos_cli: <str>

show cli commands

leaf1(config)#interface Dps ?
  $      list end
  <1-1>  DPS Tunnel Interface number
leaf1(config-if-Dp1)#?
  adjacency-segment       Set IS-IS SR adjacency segment interface configuration
  arp                     ARP config commands
  bfd                     Configure BFD specific configurations
  bgp                     Configure BGP commands
  description             Description string to associate with the interface
  dhcp                    DHCP server, client and relay interface configuration
  flow                    Interface flow config commands
  health                  Set health parameters of an interface
  igmp                    IGMP related status and configuration
  ip                      Interface IP config commands
  ipv6                    Interface IPv6 config commands
  isis                    IS-IS commands
  link                    Configure link state tracking information
  load-interval           Time used in calculating interface utilization
  logging                 Interface-related logging configuration
  mfib                    Multicast FIB
  mld                     Multicast Listener Discovery commands
  mpls                    Interface level MPLS configuration commands
  mtu                     Set IP Maximum Transmission Unit size in bytes
  multicast               Multicast routing commands
  node-segment            Configure a node segment
  ntp                     Configure NTP
  ospfv3                  OSPF Version 3
  performance-monitoring  Set performance-monitoring parameters
  pim                     Protocol Independent Multicast (PIM)
  rip                     Routing Information Protocol
  shutdown                Administratively shut off the interface
  snmp                    Set interface SNMP parameters
  tag                     Configure Tag for the interface
  tcp                     TCP
  traffic-engineering     Configure traffic-engineering
  vrf                     Specify VRF for interface
  vrrp                    Virtual Router Redundancy Protocol (VRRP)

How to test

molecule tests

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 4, 2023 13:03
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 4, 2023
@gmuloc gmuloc requested review from a team October 4, 2023 14:20
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion on keys to add to data model from the start, otherwise this LGTM!

@gmuloc gmuloc requested review from carlbuchmann and a team October 5, 2023 07:41
carlbuchmann
carlbuchmann previously approved these changes Oct 5, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested a review from a team October 10, 2023 13:30
@ClausHolbechArista ClausHolbechArista dismissed carlbuchmann’s stale review October 12, 2023 08:31

Many changes. Please review again.

"name"
]
},
"title": "Dps Interfaces"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add dps -> DPS to the key name to display_name file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done there: b9e7306

@ClausHolbechArista ClausHolbechArista requested a review from a team October 12, 2023 09:01
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit ebdff1f into aristanetworks:devel Oct 12, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants