-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add Dps1 interface #3198
Conversation
...ble_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/dps-interface.yml
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dps-interfaces.schema.yml
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dps-interfaces.schema.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small suggestion on keys to add to data model from the start, otherwise this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dps-interfaces.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/dps-interfaces.j2
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dps-interfaces.j2
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dps-interfaces.schema.yml
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/dps-interfaces.yml
Outdated
Show resolved
Hide resolved
Many changes. Please review again.
"name" | ||
] | ||
}, | ||
"title": "Dps Interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add dps -> DPS to the key name to display_name file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done there: b9e7306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Add first implementation of Dps1 interface with required fields for AutoVPN / WAN config
NOTE: While not needed to merge this PR note that current devel branch DOES NOT support
flow tracker hardware
type inflow_trackers
- #3199Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Schema using
eos_cli
escape hatch as for now it is unclear how other commands could be neededshow cli commands
How to test
molecule tests
Checklist
Repository Checklist