Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add WRED support #3192

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Feat(eos_cli_config_gen): Add WRED support #3192

merged 10 commits into from
Nov 1, 2023

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented Oct 3, 2023 •
edited
Loading

Change Summary

At the moment for Weighted Random Early Detection to be enabled on certain queues, we would need to raw cli commands or custom templates.

This change adds support to define WRED on a per queue bases using the AVD schema.

Related Issue(s)

  • No reported issues

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

This change introduces:

  • a schema for defining WRED per queue in qos-profiles
  • a schema for defining WRED per queue on ethernet interfaces
  • associated jinja templates to generate documentation and eos config

How to test

molecule test -s eos_cli_config_gen

Checklist

User Checklist

  • Review updated documentation (using make webdoc-up to locally host the updated documentation
  • Review the molecule test case and expected output

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@chetryan
FEAT: add wred config
7def73a
@chetryan
FEAT: add documentation
1dae01b 
Add generation of WRED documentation
Fix typos
@chetryan chetryan requested review from a team as code owners October 3, 2023 11:17
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 3, 2023
ClausHolbechArista
ClausHolbechArista approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for another great PR.

@ClausHolbechArista ClausHolbechArista requested a review from a team October 6, 2023 09:44
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
gmuloc
gmuloc requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like stoping after the maximum-theshold without a drop-probablity is not allowed

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/qos.cfg Outdated Show resolved Hide resolved
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
@carlbuchmann carlbuchmann marked this pull request as draft October 24, 2023 19:44
@chetryan chetryan marked this pull request as ready for review October 30, 2023 11:27
@chetryan chetryan requested a review from gmuloc October 31, 2023 09:40
@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Nov 1, 2023
carlbuchmann
carlbuchmann approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • tested congis on dut
  • review schema + documentation
  • all comments from Claus and Guillaume addressed

@carlbuchmann carlbuchmann merged commit 13d25a0 into aristanetworks:devel Nov 1, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@chetryan chetryan

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chetryan @gmuloc @carlbuchmann @ClausHolbechArista