Fix(eos_designs): Don't require "mlag_peer_l3_ipv4_pool" with full rfc5549 #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
marcusmcpeek
approved these changes
Aug 24, 2023
JulioPDX
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Don't require "mlag_peer_l3_ipv4_pool" with full rfc5549
Related Issue(s)
When using rfc5549 for both underlay and mlag overlay peerings there should be no requirement for "mlag_peer_l3_ipv4_pool".
Component(s) name
arista.avd.eos_designsProposed changes
Add checks for rfc5549 before setting fact with mlag_l3_ip.
How to test
Added molecule test coverage. Verified error before fix.
Checklist
User Checklist
Repository Checklist