Feat(eos_designs): Validation of structured_config #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
github-actions
bot
added
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
feat/eos_designs/validation-structured-config
branch
from
17e6f5b to
302064d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
carl-baillargeon
approved these changes
Aug 10, 2023
| hide_keys: true | ||
| description: |- | ||
| Custom structured config for interfaces | ||
| Note! The content of this dictionary is _not_ validated by the schema, since it can be either ethernet_interfaces or port_channel_interfaces. |
There was a problem hiding this comment.
For future perhaps we have ethernet_structured_config and port_channel_structured_config?
carlbuchmann
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Validation of structured_config
Component(s) name
arista.avd.eos_designsProposed changes
structured_configto ensure proper validation and conversion.required: truefrom schemas withtype: listandprimary_keyset. The primary key is required implicitly when parsed as a list of dicts. By removing therequired: truefrom the primary key, we avoid it being required when the item dict is referred in a$ref.How to test
Added negative unit tests and also tested manually.
Conversion was tested as part of work to develop a conversion script.
Checklist
User Checklist
Repository Checklist