Test(eos_designs): Create eos_designs deprecated vars molecule unit test #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
Vibhu-gslab
changed the title
Vibhu-gslab
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Please look into collapsing these to a single ansible host "host1" in the molecule scenario, and then use a folder "host1" under hostvars.
See the eos_cli_config_gen_deprecated_vars for example.
Maybe the mpls stuff have to be under a "host2" since it is contradicting the settings under "host1"
...vd/molecule/eos_designs_deprecated_vars/inventory/host_vars/connected_endpoints_keys_key.yml
Outdated
Show resolved
Hide resolved
Shivani-chourasiya
force-pushed
the
deprecated_vars
branch
from
e600026 to
007c8f3
Compare
Shivani-chourasiya
force-pushed
the
deprecated_vars
branch
from
007c8f3 to
d39cc2d
Compare
Shivani-chourasiya
force-pushed
the
deprecated_vars
branch
from
d39cc2d to
ae8fc03
Compare
...ble_collections/arista/avd/molecule/eos_designs_deprecated_vars/inventory/group_vars/all.yml
Outdated
Show resolved
Hide resolved
...ecule/eos_designs_deprecated_vars/inventory/host_vars/host1/connected_endpoints_keys_key.yml
Outdated
Show resolved
Hide resolved
...vd/molecule/eos_designs_deprecated_vars/inventory/host_vars/connected_endpoints_keys_key.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_deprecated_vars/inventory/hosts.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
deprecated_vars
branch
2 times, most recently
from
638a0dd to
1a8694f
Compare
...vd/molecule/eos_designs_deprecated_vars/inventory/host_vars/host1/port-channel-short-esi.yml
Outdated
Show resolved
Hide resolved
...olecule/eos_designs_deprecated_vars/inventory/host_vars/host2/network_services_keys_name.yml
Outdated
Show resolved
Hide resolved
...olecule/eos_designs_deprecated_vars/inventory/host_vars/host2/network_services_keys_name.yml
Outdated
Show resolved
Hide resolved
Shivani-chourasiya
force-pushed
the
deprecated_vars
branch
2 times, most recently
from
7a2c159 to
e5365ff
Compare
...ecule/eos_designs_deprecated_vars/inventory/host_vars/host1/connected_endpoints_keys_key.yml
Outdated
Show resolved
Hide resolved
...vd/molecule/eos_designs_deprecated_vars/inventory/host_vars/host1/port-channel-short-esi.yml
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Aug 18, 2023
Shivani-chourasiya
force-pushed
the
deprecated_vars
branch
2 times, most recently
from
8044a26 to
96237da
Compare
ClausHolbechArista
changed the title
Vibhu-gslab
force-pushed
the
deprecated_vars
branch
from
8cffb35 to
dd60792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Create a new molecule scenario containing all deprecated variables for eos_designs.
Related Issue(s)
Fixes #2947
Component(s) name
arista.avd.eos_designsChecklist
User Checklist
Repository Checklist