Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add control for redistribution of MLAG peering subnet #3069

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add control for redistribution of MLAG peering subnet

Related Issue(s)

Fixes #1415

Component(s) name

arista.avd.eos_designs

Proposed changes

    <network_services_keys.name>:
      - name: <str>
        redistribute_mlag_ibgp_peering_vrfs: <bool>
        vrfs:
          - name: <str>
            redistribute_mlag_ibgp_peering_vrfs: <bool>

See changed files for example of output.

  • Finds all VRFs where redistribution has been disabled (default=True)
    • Add MLAG peer subnet to a list of disabled subnets
      • Respects custom IP algorithms and VRF specific pools.
    • Create a single prefix-list with all subnets.
    • Create a route-map denying the prefix-list, but permitting everything else.
    • Associate the route-map to redistribute connected only on VRFs where it has been disabled.

How to test

Added molecule coverage.
Asking customers to test.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 31, 2023 12:43
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 31, 2023
@ClausHolbechArista
Copy link
Contributor Author

@kmueller68 @c-po @perimore Please take a look and test if you can find time. Feedback is much appreciated.

@kmueller68
Copy link
Contributor

@ClausHolbechArista
Christian is on parental leave. He has implemented some kind of filtering of the MLAG peering subnet in the network.
I will have a look, at it, remove current filtering in the QA environment and try to test your implementation this week.

@carlbuchmann
Copy link
Member

@ClausHolbechArista Christian is on parental leave. He has implemented some kind of filtering of the MLAG peering subnet in the network. I will have a look, at it, remove current filtering in the QA environment and try to test your implementation this week.

@kmueller68 Thanks for the update, we will wait for your feedback!

@carlbuchmann carlbuchmann self-requested a review August 4, 2023 12:40
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against a custom repo with and without non-default settings under fabric_ip_addressing - works OK. Docs and Schema are good too.

@kmueller68
Copy link
Contributor

tested it successfully against cutomer repo and eve-ng qual fabric.

      DC_OUTSIDE:
        vrf_vni: 14
        redistribute_mlag_ibgp_peering_vrfs: false
        vtep_diagnostic:
          loopback: 104

@ClausHolbechArista
Copy link
Contributor Author

tested it successfully against cutomer repo and eve-ng qual fabric.

      DC_OUTSIDE:
        vrf_vni: 14
        redistribute_mlag_ibgp_peering_vrfs: false
        vtep_diagnostic:
          loopback: 104

Thank you Karl! We will get this one merged.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 7595edb into aristanetworks:devel Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid to redistribute dc l3leaf mlag iBGP nets in VRFs to BGP
4 participants