Fix(eos_designs): Duplicate neighbor_interfaces in rfc5549 design when multiple uplinks to the same Spine #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
bjmeuer
approved these changes
Jul 21, 2023
ClausHolbechArista
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The change is to make sure that the facts do not return multiple time the same peer in the 'avd_topology_peers'
Related Issue(s)
Fixes #3053
Component(s) name
arista.avd.eos_designsProposed changes
In the facts module, when generating the
uplink_peers, used to render the 'avd_topology_peers' variable used ineos_designsmodules, make sure that each peer name is unique.How to test
First commit breaks in molecule
Second commit fixes
Checklist
Repository Checklist