Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(dhcp_provisioner): Adding support for automatic dict_to_list conversion in ztp_configuration template #3012

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Feat(dhcp_provisioner): Adding support for automatic dict_to_list conversion in ztp_configuration template #3012

merged 2 commits into from
Jul 25, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jun 28, 2023 •
edited
Loading

Change Summary

Adding support for automatic dict_to_list conversion in ztp_configuration template

Related Issue(s)

Fixes #3002

Component(s) name

arista.avd.dhcp_provisioner

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested review from a team as code owners June 28, 2023 12:49
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft June 28, 2023 12:49
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review June 29, 2023 04:27
tgodaA
tgodaA approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from gmuloc July 6, 2023 08:56
gmuloc
gmuloc reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shivani-chourasiya - any chance we can add a test to make sure this does not break in either case

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 10, 2023
@Shivani-chourasiya
Copy link
Contributor Author

@Shivani-chourasiya - any chance we can add a test to make sure this does not break in either case

Sure

@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 10, 2023 12:35
@Shivani-chourasiya Shivani-chourasiya force-pushed the issue_3002 branch 2 times, most recently from 927a740 to 89c2c45 Compare July 11, 2023 07:25
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Jul 11, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 12, 2023
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 12, 2023 08:37
@Shivani-chourasiya
Copy link
Contributor Author

@Shivani-chourasiya - any chance we can add a test to make sure this does not break in either case

Added!

@Shivani-chourasiya Shivani-chourasiya force-pushed the issue_3002 branch 2 times, most recently from a8a723c to 33c6c56 Compare July 24, 2023 08:50
carlbuchmann
carlbuchmann approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 7cce083 into aristanetworks:devel Jul 25, 2023
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees
No one assigned
Labels
rn: Feat(dhcp_provisioner) role: dhcp_provisioner state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support list-of-dicts node_groups and node lists in dhcp_provisioner
6 participants
@Shivani-chourasiya @gmuloc @carlbuchmann @ClausHolbechArista @tgodaA @Shivani-gslab