Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Support vars on play via vars or vars_files #2999

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix(eos_cli_config_gen): Support vars on play via vars or vars_files #2999

merged 3 commits into from
Jul 24, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 21, 2023 •
edited
Loading

Change Summary

Support vars on play via vars or vars_files

Related Issue(s)

Fixes #2711

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fix variable parsing in eos_cli_config_gen to also read variables set on "play".

How to test

  • Added molecule test and tested before and after the change.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 21, 2023
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Support for play_vars Fix(eos_cli_config_gen): Add support for setting vars on play via vars or vars_files Jul 3, 2023
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Add support for setting vars on play via vars or vars_files Fix(eos_cli_config_gen): Support vars on play via vars or vars_files Jul 3, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 3, 2023 11:04
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 3, 2023 11:04
carlbuchmann
carlbuchmann approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from a team July 13, 2023 19:37
@ClausHolbechArista ClausHolbechArista added this to the v4.2.0 milestone Jul 24, 2023
@gmuloc gmuloc merged commit bfa7f3e into aristanetworks:devel Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

Play vars / vars_files are ignored by eos_cli_config_gen
3 participants
@ClausHolbechArista @gmuloc @carlbuchmann