Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Support multiple descriptions in connected_endpoint adapters #2966

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Feat(eos_designs): Support multiple descriptions in connected_endpoint adapters #2966

merged 6 commits into from
Sep 7, 2023

Conversation

pvinci-arista
Copy link
Contributor

@pvinci-arista pvinci-arista commented Jun 7, 2023 •
edited by gmuloc
Loading

Change Summary

support individual descriptions following the existing model for L3_interfaces

Related Issue(s)

Fixes #2952

Component(s) name

arista.avd.eos_designs

Proposed changes

Add a new key for descriptions.

  - name: OLD_SW-1/7
    adapters:
      - switches: [connected_endpoints, connected_endpoints]
        switch_ports: [Ethernet9, Ethernet10]
        descriptions: ["PHYSICAL_PORT_DESCRIPTION_1", "PHYSICAL_PORT_DESCRIPTION_2"]
        port_channel:
          mode: "active"
          description: "PORT_CHANNEL_DESCRIPTION"

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@pvinci-arista pvinci-arista requested a review from a team as a code owner June 7, 2023 05:25
@pvinci-arista pvinci-arista self-assigned this Jun 7, 2023
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 7, 2023
@pvinci-arista pvinci-arista added this to the v4.1.0 milestone Jun 7, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann force-pushed the connected_descriptions branch from 2731b3a to 33bb188 Compare June 16, 2023 20:19
@carlbuchmann carlbuchmann requested a review from a team as a code owner June 16, 2023 20:19
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 16, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann requested a review from a team June 21, 2023 01:08
@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented Jul 3, 2023 •
edited
Loading

Moving to draft until schema has been rearranged.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft July 3, 2023 06:53
@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role and removed type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jul 13, 2023
@pvinci-arista pvinci-arista marked this pull request as ready for review July 13, 2023 14:47
gmuloc
gmuloc requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a negative test when descriptions is not of the correct length in the eos_designs_negative_unit_tests scenario

...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jul 24, 2023
@carlbuchmann carlbuchmann marked this pull request as draft August 4, 2023 12:29
@gmuloc gmuloc force-pushed the connected_descriptions branch from 3837519 to a5843ec Compare September 5, 2023 09:08
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc marked this pull request as ready for review September 5, 2023 09:17
@gmuloc gmuloc requested a review from a team September 5, 2023 09:18
@gmuloc gmuloc requested a review from a team September 5, 2023 09:18
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): support multiple descriptions in connected_endpoint adapter rather than a unique one Feat(eos_designs): support multiple descriptions in connected_endpoint adapters Sep 5, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): support multiple descriptions in connected_endpoint adapters Feat(eos_designs): Support multiple descriptions in connected_endpoint adapters Sep 5, 2023
@ClausHolbechArista ClausHolbechArista merged commit 00ed6d7 into aristanetworks:devel Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA left review comments

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@pvinci-arista pvinci-arista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.4.0-dev1
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): support multiple descriptions in connected_endpoint adapter rather than a unique one
4 participants
@pvinci-arista @ClausHolbechArista @gmuloc @tgodaA