Feat(eos_cli_config_gen): Add Trident MMU queue #2835
Merged
+636
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the support for defining queue settings for the Memory Management Unit on Trident platforms.
github-actions
bot
added
role: eos_cli_config_gen
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/platform.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/platform.j2
Outdated
Show resolved
Hide resolved
Add the support for defining queue settings for the Memory Management Unit on Trident platforms.
carlbuchmann
force-pushed
the
add_mmu_profile
branch
from
24713e8 to
28cc957
Compare
github-actions
bot
removed
the
role: eos_designs
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/platform.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/platform.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/platform.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/platform.j2
Outdated
Show resolved
Hide resolved
…tes/documentation/platform.j2 Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
approved these changes
Jul 28, 2023
| required: true | ||
| min: 0 | ||
| max: 7 | ||
| unit: |
There was a problem hiding this comment.
to make this more intuitive I would suggest to rename to reserved_unit
There was a problem hiding this comment.
I would expect this unit to also impact the unit of the thresholds, but I don't know. We should verify on EOS.
| required: true | ||
| min: 0 | ||
| max: 7 | ||
| unit: |
There was a problem hiding this comment.
to make this more intuitive I would suggest to rename to reserved_unit
carlbuchmann
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support for defining queue settings for the Memory Management Unit on Trident platforms.
Change Summary
At the moment, changing the default profile for the Memory Management Unit (MMU) on Trident platforms is only possible via
eos_cli.This change adds the functionality to
eos_cli_config_gento accept this as part of the data model.Related Issue(s)
No current Issues raised.
Component(s) name
arista.avd.eos_cli_config_genProposed changes
eos/platform.j2to generate device configdocumentation/platform.j2to generate matching Markdown docs for devicesHow to test
molecule test -s eos_cli_config_genChecklist
User Checklist
platform.mdand give feedback whether this is clear enough.platform.cfgand comment on any improvements requiredRepository Checklist