Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_snapshot): Conditional in tasks are not honored and support for limit #2457

Conversation

carlbuchmann
Copy link
Member

Change Summary

Update conditionals when on tasks as they were not being honored.
Update YAML and JSON output templates to support limit.

Component(s) name

arista.avd.snapshot

How to test

Tested with ATD environment with all output formats (one by one and all) and with and without--limit optionl.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carlbuchmann carlbuchmann added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Jan 23, 2023
@carlbuchmann carlbuchmann added this to the 3.8.1 milestone Jan 23, 2023
@carlbuchmann carlbuchmann requested a review from a team as a code owner January 23, 2023 16:46
@carlbuchmann carlbuchmann added the type: bug Something isn't working label Jan 23, 2023
@carlbuchmann carlbuchmann changed the title Fix(eos_snapshot) conditional in tasks are not honored and support for limit Fix(eos_snapshot): Conditional in tasks are not honored and support for limit Jan 23, 2023
@sugetha24 sugetha24 assigned sugetha24 and unassigned sugetha24 Jan 23, 2023
@sugetha24 sugetha24 self-requested a review January 23, 2023 19:02
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 83c8052 into aristanetworks:devel Jan 23, 2023
carlbuchmann added a commit to carlbuchmann/avd that referenced this pull request Jan 23, 2023
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Jan 23, 2023
@carlbuchmann carlbuchmann deleted the fix-eos-snapshot-conditional-limit branch April 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants