Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Detect duplicate VLAN, VRF, VNI within network_services (#2411) #2449

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix(eos_designs): Detect duplicate VLAN, VRF, VNI within network_services (#2411) #2449

merged 1 commit into from
Jan 20, 2023

Conversation

carlbuchmann
Copy link
Member

Cherry-pick of #2411 for 3.8.1 release

@carlbuchmann carlbuchmann requested a review from a team as a code owner January 20, 2023 15:33
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 20, 2023
@carlbuchmann carlbuchmann changed the title Fix(eos_designs): Detect duplicate VLAN, VRF, VNI within network_serv… Fix(eos_designs): Detect duplicate VLAN, VRF, VNI within network_services (#2411) Jan 20, 2023
gmuloc
gmuloc approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍒

tgodaA
tgodaA approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added this to the 3.8.1 milestone Jan 20, 2023
@carlbuchmann carlbuchmann merged commit 27d248d into aristanetworks:releases/v3.8.x Jan 20, 2023
@carlbuchmann carlbuchmann deleted the cherry-pick-2411 branch April 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
cherry-pick rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@carlbuchmann @gmuloc @tgodaA @ClausHolbechArista