Fix(eos_designs): Properly strip empty strings

aristanetworks · Dec 18, 2023 · 8dfa152 · 8dfa152
1 parent 0ab1a93
commit 8dfa152
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/...ons/arista/avd/molecule/eos_designs_unit_tests/intended/configs/network-ports-tests.1.cfg b/...ons/arista/avd/molecule/eos_designs_unit_tests/intended/configs/network-ports-tests.1.cfg
@@ -539,22 +539,18 @@ interface Ethernet14
    switchport
 !
 interface Ethernet51
-   description 
    shutdown
    switchport
 !
 interface Ethernet52
-   description 
    shutdown
    switchport
 !
 interface Ethernet53
-   description 
    shutdown
    switchport
 !
 interface Ethernet54
-   description 
    shutdown
    switchport
 !

diff --git a/...avd/molecule/eos_designs_unit_tests/intended/structured_configs/network-ports-tests.1.yml b/...avd/molecule/eos_designs_unit_tests/intended/structured_configs/network-ports-tests.1.yml
@@ -671,22 +671,18 @@ ethernet_interfaces:
   type: switched
 - name: Ethernet51
   peer_type: network_port
-  description: ''
   shutdown: true
   type: switched
 - name: Ethernet52
   peer_type: network_port
-  description: ''
   shutdown: true
   type: switched
 - name: Ethernet53
   peer_type: network_port
-  description: ''
   shutdown: true
   type: switched
 - name: Ethernet54
   peer_type: network_port
-  description: ''
   shutdown: true
   type: switched
 mlag_configuration:

diff --git a/...ns/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py b/...ns/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py
@@ -181,4 +181,4 @@ def _get_ethernet_interface_cfg(self, adapter: dict, node_index: int, connected_
         if (flowcontrol_received := get(adapter, "flowcontrol.received")) is not None:
             ethernet_interface["flowcontrol"] = {"received": flowcontrol_received}
 
-        return strip_null_from_data(ethernet_interface)
+        return strip_null_from_data(ethernet_interface, strip_values_tuple=(None, ""))