addressing comments

aristanetworks · Nov 7, 2024 · 7506a95 · 7506a95
1 parent 4beff5a
commit 7506a95
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/...ta/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md b/...ta/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
@@ -221,7 +221,6 @@ sFlow is disabled.
 | Interface | Group Name | Direction |
 | --------- | ---------- | --------- |
 | Ethernet1 | EVPN_MH_ES1 | upstream |
-| Ethernet1 | EVPN_MH_ES3 | upstream |
 | Ethernet1 | EVPN_MH_ES3, EVPN_MH_ES4 | upstream |
 | Ethernet3 | EVPN_MH_ES2 | downstream |
 

diff --git a/...vd/molecule/eos_cli_config_gen/documentation/devices/port-channel-interfaces.md b/...vd/molecule/eos_cli_config_gen/documentation/devices/port-channel-interfaces.md
@@ -330,7 +330,6 @@ interface Ethernet50
 | Interface | Group Name | Direction |
 | --------- | ---------- | --------- |
 | Port-Channel5 | EVPN_MH_ES1 | downstream |
-| Port-Channel5 | EVPN_MH_ES3 | downstream |
 | Port-Channel5 | EVPN_MH_ES3, EVPN_MH_ES4 | downstream |
 | Port-Channel15 | EVPN_MH_ES2 | upstream |
 

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
@@ -335,11 +335,8 @@
 | {{ link_tracking_interface.name }} | {{ link_tracking_group.name }} | {{ link_tracking_group.direction }} |
 {%                 endif %}
 {%             endfor %}
-{%             if link_tracking_interface.link_tracking.direction is arista.avd.defined %}
-{%                 for group_name in link_tracking_interface.link_tracking.groups | arista.avd.natural_sort('name') %}
-{%                     do link_tracking_group_name.append(group_name) %}
-| {{ link_tracking_interface.name }} | {{ link_tracking_group_name | join(', ') }} | {{ link_tracking_interface.link_tracking.direction }} |
-{%                 endfor %}
+{%             if link_tracking_interface.link_tracking.direction is arista.avd.defined and link_tracking_interface.link_tracking.groups is arista.avd.defined %}
+| {{ link_tracking_interface.name }} | {{ link_tracking_interface.link_tracking.groups | join(', ') }} | {{ link_tracking_interface.link_tracking.direction }} |
 {%             endif %}
 {%         endfor %}
 {%     endif %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
@@ -292,11 +292,8 @@
 | {{ link_tracking_interface.name }} | {{ link_tracking_group.name }} | {{ link_tracking_group.direction }} |
 {%                 endif %}
 {%             endfor %}
-{%             if link_tracking_interface.link_tracking.direction is arista.avd.defined %}
-{%                 for group_name in link_tracking_interface.link_tracking.groups %}
-{%                     do link_tracking_group_name.append(group_name) %}
-| {{ link_tracking_interface.name }} | {{ link_tracking_group_name | join(', ') }} | {{ link_tracking_interface.link_tracking.direction }} |
-{%                 endfor %}
+{%             if link_tracking_interface.link_tracking.direction is arista.avd.defined and link_tracking_interface.link_tracking.groups is arista.avd.defined %}
+| {{ link_tracking_interface.name }} | {{ link_tracking_interface.link_tracking.groups | join(', ') }} | {{ link_tracking_interface.link_tracking.direction }} |
 {%             endif %}
 {%         endfor %}
 {%     endif %}