Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta): Fix ResultManager statistics #962

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Dec 10, 2024

Description

Fix ResultManager statistics. ResultManager stats are only updated when needed.

Fixes #948

Checklist:

  • Update documentation
  • Update unit tests

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #962 will degrade performances by 17.22%

Comparing carl-baillargeon:fix/issue_948 (f16a835) with main (6ee2c08)

Summary

⚡ 4 improvements
❌ 2 (👁 2) regressions
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main carl-baillargeon:fix/issue_948 Change
test_anta_dry_run[1-device] 61.2 ms 53.9 ms +13.61%
test_anta_dry_run[2-devices] 108.2 ms 94.6 ms +14.39%
👁 test_table_devices[1-device] 240 µs 277.2 µs -13.42%
👁 test_table_devices[2-devices] 251.4 µs 303.7 µs -17.22%
test_get_coroutines[1-device] 47.6 ms 40.3 ms +18%
test_get_coroutines[2-devices] 93.2 ms 79.5 ms +17.32%

@carl-baillargeon carl-baillargeon marked this pull request as ready for review December 11, 2024 00:40
anta/runner.py Show resolved Hide resolved
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we can approve the codspeed impact

@gmuloc gmuloc merged commit f702c91 into aristanetworks:main Dec 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: anta nrfu table --group-by is broken
2 participants