Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Adjust revision for show management cvx #956

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Dec 9, 2024

Description

Test is throwing error when run on a a device not running CVX at all. Looking at the unit tests, it feels the revision for the command should be 3 and not 1 (cf issue comments)

Fixes #953

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #956 will not alter performance

Comparing fix/953 (dc5f75d) with main (0c32b83)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sarunac sarunac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit 23d8c2b into main Dec 12, 2024
24 checks passed
@gmuloc gmuloc deleted the fix/953 branch December 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: VerifyManagementCVX should not throw an error
3 participants