Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Second round of cleaning up BGP tests module #914

Merged
merged 26 commits into from
Dec 24, 2024

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Nov 6, 2024

Description

Refactoring BGP tests module to address the following issues:

WARNING: NEED TO MERGE #888 BEFORE

To-do list:

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #914 will not alter performance

Comparing carl-baillargeon:fix/bgp_modules_v2 (a61274d) with main (3b97984)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum marked this pull request as ready for review November 14, 2024 10:29
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carl-baillargeon carl-baillargeon added this to the v1.2.0 milestone Nov 25, 2024
@vitthalmagadum vitthalmagadum marked this pull request as draft November 26, 2024 13:25
@vitthalmagadum vitthalmagadum marked this pull request as ready for review November 28, 2024 11:06
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/input_models/routing/bgp.py Outdated Show resolved Hide resolved
anta/input_models/routing/bgp.py Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Mulocher <[email protected]>
@gmuloc gmuloc merged commit d8d9690 into aristanetworks:main Dec 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants