Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta)!: Fix tags behavior to reflect the documentation #903

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Description

#827 fixed multiple --tags CLI support but introduced an issue where test-to-device tag matching wasn't properly enforced.

This PR now reflects the behavior specified in the Tag Management documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #903 will improve performances by 15.45%

Comparing carl-baillargeon:fix/tags_again (c93f9e1) with main (fe94dfb)

🎉 Hooray! pytest-codspeed just leveled up to 3.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 2 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark main carl-baillargeon:fix/tags_again Change
test_get_coroutines[1-device] 55.1 ms 47.7 ms +15.45%
test_get_coroutines[2-devices] 107.3 ms 93.7 ms +14.45%

anta/runner.py Outdated Show resolved Hide resolved
@gmuloc gmuloc modified the milestones: v2.0.0, v1.2.0 Oct 30, 2024
@gmuloc gmuloc changed the title fix(anta): Fix tags behavior to reflect the documentation fix(anta)!: Fix tags behavior to reflect the documentation Oct 30, 2024
Copy link

@gmuloc gmuloc merged commit 898fdd3 into aristanetworks:main Oct 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants