Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix wrong example commands #893

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Oct 21, 2024

Description

Fix issue in doc

Fixes #892

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Doc: Fix wrong example commands doc: Fix wrong example commands Oct 21, 2024
@gmuloc
Copy link
Collaborator Author

gmuloc commented Oct 21, 2024

@carl-baillargeon / @mtache / @titom73

extra suggestion from the issue reporter would be to move tags example out of "getting started" -> thoughts?

@mtache
Copy link
Collaborator

mtache commented Oct 23, 2024

@carl-baillargeon / @mtache / @titom73

extra suggestion from the issue reporter would be to move tags example out of "getting started" -> thoughts?

Agreed :) Please remove tags example.

@gmuloc gmuloc added this to the v1.2.0 milestone Oct 28, 2024
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@carl-baillargeon carl-baillargeon merged commit 3649f54 into aristanetworks:main Oct 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Doc is wrong for anta nrfu table example
4 participants