Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added the test case to verify SNMP error counters #836

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies the number of SNMP error counter(s) processed.

By default, all  error counters will be checked for any non-zero values.
An optional list of specific error counters can be provided for granular testing.

Expected Results
----------------
* Success: The test will pass if the SNMP error counter(s) are zero/None.
* Failure: The test will fail if the SNMP error counter(s) are non-zero/not None/Not Found or is not configured.

Fixes #834

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Show resolved Hide resolved
tests/units/anta_tests/test_snmp.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #836 will not alter performance

Comparing vitthalmagadum:issue_834 (abbfc3f) with main (839f70a)

Summary

✅ 8 untouched benchmarks

anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@carl-baillargeon carl-baillargeon merged commit 5483b97 into aristanetworks:main Oct 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the test case to verify SNMP error counters
3 participants