Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added the test case to verify Inbound/outbound stats for BGP neighbors #778

Merged
merged 6 commits into from
Aug 15, 2024
Merged

feat(anta): Added the test case to verify Inbound/outbound stats for BGP neighbors #778

merged 6 commits into from
Aug 15, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

This test case checks if specified BGP drop statistics are zero, ensuring that no BGP messages
are being dropped.(Inbound updates, Inbound paths, Outbound paths).

Expected Results
----------------
* Success: The test will pass if the BGP peer's drop statistics are zero.
* Failure: The test will fail if the BGP peer's drop statistics are non-zero.

Fixes #769

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft August 6, 2024 12:45
@carl-baillargeon carl-baillargeon mentioned this pull request Aug 7, 2024
Merged
6 tasks
@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 8, 2024 13:20
carl-baillargeon
carl-baillargeon approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carl-baillargeon carl-baillargeon merged commit c37c089 into aristanetworks:main Aug 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify Inbound/outbound stats for BGP neighbors
2 participants
@vitthalmagadum @carl-baillargeon