-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anta): Added test case to verify registered protocol for IPv4 BFD peers #773
Merged
carl-baillargeon
merged 6 commits into
aristanetworks:main
from
vitthalmagadum:issue_766
Aug 21, 2024
Merged
feat(anta): Added test case to verify registered protocol for IPv4 BFD peers #773
carl-baillargeon
merged 6 commits into
aristanetworks:main
from
vitthalmagadum:issue_766
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitthalmagadum
force-pushed
the
issue_766
branch
from
August 5, 2024 06:07
cf88c64
to
904755b
Compare
vitthalmagadum
force-pushed
the
issue_766
branch
from
August 12, 2024 12:43
904755b
to
8692cd9
Compare
vitthalmagadum
changed the title
feat(anta): Added registered protocol optional check to VerifyBFDSpecificPeers test case
feat(anta): Added test case to verify registered protocol for IPv4 BFD peers
Aug 12, 2024
vitthalmagadum
force-pushed
the
issue_766
branch
from
August 16, 2024 04:13
8692cd9
to
91dd124
Compare
Quality Gate passedIssues Measures |
carl-baillargeon
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I changed the result failure message to have the missing protocols instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All neighbor IPs where PEER_GROUP has BFD_ENABLED=true should be displayed with respective registered protocol(i.e ISIS or BGP etc)
Note: Added revision fix in VerifyBFDPeersIntervals, VerifyBFDSpecificPeers revision 1 as later revision introduces additional nesting for type
Fixes #766
Checklist:
pre-commit run
)tox -e testenv
)