Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Opt-in for Secret-scanner workflow #696

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jun 5, 2024

Description

follow recommendation from aristanetwork org - the scanner will prevent secrets to be committed to the main branch.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc merged commit 35a4bdd into aristanetworks:main Jun 5, 2024
12 of 13 checks passed
@github-actions github-actions bot added the rn: ci label Jun 5, 2024
@gmuloc gmuloc deleted the ci-add-secret-scanner branch January 15, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant