-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anta): Optimize device to tests creation in ANTA runner #648
Merged
gmuloc
merged 21 commits into
aristanetworks:main
from
carl-baillargeon:refactor/runner
Apr 25, 2024
Merged
fix(anta): Optimize device to tests creation in ANTA runner #648
gmuloc
merged 21 commits into
aristanetworks:main
from
carl-baillargeon:refactor/runner
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
requested changes
Apr 23, 2024
gmuloc
changed the title
fix(anta): Refactor ANTA runner
fix(anta): Optimize (a lot) (test, device) tuples creation in ANTA runner
Apr 23, 2024
gmuloc
reviewed
Apr 23, 2024
carl-baillargeon
changed the title
fix(anta): Optimize (a lot) (test, device) tuples creation in ANTA runner
fix(anta): Optimize device to tests creation in ANTA runner
Apr 23, 2024
6 tasks
gmuloc
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor ANTA runner to use indexes for tags for faster execution. Also moved some of the logic outside of the main function for clarity and manageability.
Updated unit tests.
Fixes # (issue id)
Checklist:
pre-commit run
)tox -e testenv
)