Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide (error|failure|success|skipped) to hide results. #588

Merged
merged 31 commits into from
Mar 29, 2024

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Mar 18, 2024

Description

Implement some cli enhancements:

  • Add --device and --test to anta nrfu to filter by tests or devices. Can be used multiple times.
  • Honor device and test filters at runner level: no undesired API calls are done towards devices
  • Implement --hide (error|failure|success|skipped) to anta nrfu hide test in results

Fixes #585

Example with device and test

image

Example of skip-error,failure,success

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

anta/cli/nrfu/__init__.py Outdated Show resolved Hide resolved
anta/cli/nrfu/__init__.py Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 marked this pull request as ready for review March 20, 2024 15:02
@titom73 titom73 added framework-enhancement New feature or request Anta CLI All things around CLI labels Mar 20, 2024
@titom73 titom73 force-pushed the fix/issue585-cli-more-consistent branch from 9dd847b to 0dbf8bf Compare March 20, 2024 16:04
@gmuloc gmuloc added this to the v1.0.0 milestone Mar 22, 2024
pyproject.toml Outdated Show resolved Hide resolved
pylintrc Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mtache mtache force-pushed the fix/issue585-cli-more-consistent branch from 0dbf8bf to c537baa Compare March 28, 2024 07:55
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

docs/cli/nrfu.md Outdated Show resolved Hide resolved
docs/cli/nrfu.md Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
docs/cli/nrfu.md Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mtache mtache changed the title feat(anta.cli): Make anta nrfu CLI more consistent feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide(error|failure|success) to hide results. Mar 28, 2024
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/cli/debug/commands.py Show resolved Hide resolved
anta/cli/nrfu/__init__.py Outdated Show resolved Hide resolved
anta/cli/nrfu/utils.py Outdated Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
docs/cli/nrfu.md Outdated Show resolved Hide resolved
docs/cli/nrfu.md Show resolved Hide resolved
tests/units/anta_tests/test_field_notices.py Outdated Show resolved Hide resolved
@mtache mtache changed the title feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide(error|failure|success) to hide results. feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide (error|failure|success|skipped) to hide results. Mar 29, 2024
@mtache mtache force-pushed the fix/issue585-cli-more-consistent branch from 22fb699 to 40d6a60 Compare March 29, 2024 12:21
@mtache mtache merged commit b2dadb1 into aristanetworks:main Mar 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anta CLI All things around CLI framework-enhancement New feature or request rn: feat(anta.cli)
Projects
None yet
3 participants