feat(anta.tests): Added testcase to verify router path-selection paths #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vibhu-gslab
reviewed
Mar 14, 2024
gmuloc
requested changes
Mar 28, 2024
gmuloc
reviewed
Apr 18, 2024
anta/tests/path_selection.py
Outdated
| name = "VerifyRouterPathsHealth" | ||
| description = "Verifies the route and telemetry state of all paths under router path-selection." | ||
| categories: ClassVar[list[str]] = ["path-selection"] | ||
| commands: ClassVar[list[AntaCommand | AntaTemplate]] = [AntaCommand(command="show path-selection paths")] |
gmuloc
requested changes
Apr 18, 2024
anta/tests/path_selection.py
Outdated
Comment on lines
64
to
66
| # If the route state of any path is not 'ipsecEstablished' or 'routeResolved', the test fails | ||
| if route_state not in ["ipsecEstablished", "routeResolved"]: | ||
| self.result.is_failure(f"Route state for peer {peer} in group {group} is `{route_state}`.") |
There was a problem hiding this comment.
so here we could even imagine checking that if IPsec is enabled for the path-group for dynamic peers, we expect ipsecEstablished otherwise routeResolved. It would mean also retrieving the `show running-config path-seleciton
anta/tests/path_selection.py
Outdated
|
|
||
| # If the telemetry state of any path is inactive, the test fails | ||
| elif not session: | ||
| self.result.is_failure(f"Telemetry state for peer {peer} in group {group} is `inactive`.") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"Telemetry state for peer {peer} in group {group} is `inactive`.") | |
| self.result.is_failure(f"Telemetry state for peer {peer} in path-group {group} is `inactive`.") |
anta/tests/path_selection.py
Outdated
|
|
||
| Expected Results | ||
| ---------------- | ||
| * Success: The test will pass if all paths under router path-selection have their route state as either 'IPsec established' or 'Resolved' |
There was a problem hiding this comment.
Suggested change
| * Success: The test will pass if all paths under router path-selection have their route state as either 'IPsec established' or 'Resolved' | |
| * Success: The test will pass if all path states under router path-selection are either 'IPsec established' or 'Resolved' |
anta/tests/path_selection.py
Outdated
| ---------------- | ||
| * Success: The test will pass if all paths under router path-selection have their route state as either 'IPsec established' or 'Resolved' | ||
| and their telemetry state as 'active'. | ||
| * Failure: The test will fail if router path-selection is not configured, any path's route state is not 'IPsec established' or 'Resolved', |
There was a problem hiding this comment.
Missing telemetry active check in the docstring (to be added) and reword like this:
Suggested change
| * Failure: The test will fail if router path-selection is not configured, any path's route state is not 'IPsec established' or 'Resolved', | |
| * Failure: The test will fail if router path-selection is not configured or if any path state is not 'IPsec established' or 'Resolved', |
anta/tests/path_selection.py
Outdated
| -------- | ||
| ```yaml | ||
| anta.tests.path_selection: | ||
| - VerifyRouterPathsHealth: |
There was a problem hiding this comment.
Suggested change
| - VerifyRouterPathsHealth: | |
| - VerifyPathsHealth: |
anta/tests/path_selection.py
Outdated
| self.result.is_failure(f"Telemetry state for peer {peer} in group {group} is `inactive`.") | ||
|
|
||
|
|
||
| class VerifySpecificRouterPath(AntaTest): |
There was a problem hiding this comment.
Suggested change
| class VerifySpecificRouterPath(AntaTest): | |
| class VerifySpecificPath(AntaTest): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added testcase to verify router path-selection paths.
VerifyRouterPathsHealth
"""
Verifies the route and telemetry state of all paths under router path-selection.
The expected states are 'IPsec established', 'Resolved' for route and 'active' for telemetry.
"""
VerifySpecificRouterPath
"""
Verifies the route and telemetry state of a specific path for an IPv4 peer under router path-selection.
The expected states are 'IPsec established', 'Resolved' for route and 'active' for telemetry.
"""
Fixes #577
Checklist:
pre-commit run)tox -e testenv)