Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta.tests): Added testcase to verify IP security connection #575

Merged
merged 10 commits into from
Apr 12, 2024

Conversation

MaheshGSLAB
Copy link
Collaborator

Description

Added testcase to verify IP security connection

Fixes #567

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review March 8, 2024 04:57
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tests/security.py Outdated Show resolved Hide resolved
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 8, 2024 07:15
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Show resolved Hide resolved
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 10, 2024 13:20
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaheshGSLAB lets discuss tomorrow but I had to replace the "null" with None as this is what JSON null becomes in python.

@gmuloc gmuloc added this to the v1.0.0 milestone Apr 12, 2024
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc April 12, 2024 13:15
@gmuloc gmuloc merged commit 00fba99 into aristanetworks:main Apr 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to validate IP sec connection status
2 participants