Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta): Catalog issues when parsed data has the wrong type #462

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 15, 2023

Description

More Guards

Fixes #457
Fixes #460

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.0.0 milestone Nov 15, 2023
@gmuloc gmuloc requested a review from mtache November 16, 2023 22:19
@titom73 titom73 changed the title fix: Catalog issues when parsed data has the wrong type fix(anta): Catalog issues when parsed data has the wrong type Nov 19, 2023
Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just refactored parse() to use the code from from_dict() to avoid code duplication.

@gmuloc gmuloc merged commit 83765fe into aristanetworks:main Nov 21, 2023
19 checks passed
@titom73 titom73 mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anta fails to load inventory Empty test catalog file leads to traceback
2 participants