Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cv_configlet module to add configlets_notes optional parameter #186

Merged
merged 1 commit into from
Apr 24, 2020
Merged

update cv_configlet module to add configlets_notes optional parameter #186

merged 1 commit into from
Apr 24, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Apr 22, 2020

Types of changes

  • New feature (non-breaking change which adds functionality)

Proposed changes

I updated the module cv_configlet to add the optional parameter configlets_notes.
The default value is Managed by Ansible

How to test

Run a playbook using the cv_configlet with and without the parameter configlets_notes.
Double check the notes in CVP GUI (menu provisionning/configlets)
Example:

---
- name: lab03 - cv_configlet lab
  hosts: CloudVision
  connection: local
  gather_facts: no

  tasks:
    - name: "Gather CVP facts {{inventory_hostname}}"
      arista.cvp.cv_facts:
        facts:
          configlets
      register: CVP_FACTS

    - name: "Configure configlet on {{inventory_hostname}}"
      arista.cvp.cv_configlet:
        cvp_facts: "{{CVP_FACTS.ansible_facts}}"
        configlets: "{{CVP_CONFIGLETS}}"
        configlets_notes: "This configlet is managed by Ansible"
        configlet_filter: ["TRAINING"]
        state: present

Checklist:

  • I have updated the documentation accordingly.

@titom73 titom73 self-requested a review April 22, 2020 15:20
@titom73 titom73 added module: cv_configlet Issue related to cv_configlet module status: To be merged Issue solved in a volatile branch type: enhancement New feature or request and removed status: To be merged Issue solved in a volatile branch labels Apr 24, 2020
@titom73 titom73 merged commit 325d3e9 into aristanetworks:releases/v1.1.x Apr 24, 2020
@titom73 titom73 added the status: testing PR under testing label Apr 24, 2020
@titom73 titom73 mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cv_configlet Issue related to cv_configlet module status: testing PR under testing type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants